Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: Source/core/rendering/RenderBoxModelObject.cpp

Issue 23102018: Refactoring DrawLooper so that it can apply shadow effects as skia image filters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Adding missing adoptRefs Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/core/rendering/svg/SVGInlineTextBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 2495 matching lines...) Expand 10 before | Expand all | Expand 10 after
2506 rectToClipOut.inflate(-1); 2506 rectToClipOut.inflate(-1);
2507 } 2507 }
2508 2508
2509 if (!rectToClipOut.isEmpty()) { 2509 if (!rectToClipOut.isEmpty()) {
2510 context->clipOut(rectToClipOut); 2510 context->clipOut(rectToClipOut);
2511 } 2511 }
2512 } 2512 }
2513 } 2513 }
2514 2514
2515 // Draw only the shadow. 2515 // Draw only the shadow.
2516 DrawLooper drawLooper; 2516 RefPtr<DrawLooper> drawLooper = adoptRef(new DrawLooper);
2517 drawLooper.addShadow(shadowOffset, shadowBlur, shadowColor, 2517 drawLooper->addShadow(shadowOffset, shadowBlur, shadowColor,
2518 DrawLooper::ShadowRespectsTransforms, DrawLooper::ShadowIgnoresA lpha); 2518 DrawLooper::ShadowRespectsTransforms, DrawLooper::ShadowIgnoresA lpha);
2519 context->setDrawLooper(drawLooper); 2519 context->setDrawLooper(drawLooper.release());
2520 2520
2521 if (hasBorderRadius) { 2521 if (hasBorderRadius) {
2522 RoundedRect influenceRect(shadowRect, border.radii()); 2522 RoundedRect influenceRect(shadowRect, border.radii());
2523 influenceRect.expandRadii(2 * shadowBlur + shadowSpread); 2523 influenceRect.expandRadii(2 * shadowBlur + shadowSpread);
2524 if (allCornersClippedOut(influenceRect, info.rect)) 2524 if (allCornersClippedOut(influenceRect, info.rect))
2525 context->fillRect(fillRect.rect(), Color::black); 2525 context->fillRect(fillRect.rect(), Color::black);
2526 else { 2526 else {
2527 fillRect.expandRadii(shadowSpread); 2527 fillRect.expandRadii(shadowSpread);
2528 if (!fillRect.isRenderable()) 2528 if (!fillRect.isRenderable())
2529 fillRect.adjustRadii(); 2529 fillRect.adjustRadii();
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
2786 ASSERT(!beforeChild || toBoxModelObject == beforeChild->parent()); 2786 ASSERT(!beforeChild || toBoxModelObject == beforeChild->parent());
2787 for (RenderObject* child = startChild; child && child != endChild; ) { 2787 for (RenderObject* child = startChild; child && child != endChild; ) {
2788 // Save our next sibling as moveChildTo will clear it. 2788 // Save our next sibling as moveChildTo will clear it.
2789 RenderObject* nextSibling = child->nextSibling(); 2789 RenderObject* nextSibling = child->nextSibling();
2790 moveChildTo(toBoxModelObject, child, beforeChild, fullRemoveInsert); 2790 moveChildTo(toBoxModelObject, child, beforeChild, fullRemoveInsert);
2791 child = nextSibling; 2791 child = nextSibling;
2792 } 2792 }
2793 } 2793 }
2794 2794
2795 } // namespace WebCore 2795 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/core/rendering/svg/SVGInlineTextBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698