Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 23102017: DevTools: fix source maps loading from file scheme urls. (Closed)

Created:
7 years, 4 months ago by vsevik
Modified:
7 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: fix source maps loading from file scheme urls. BUG=277729 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156706

Patch Set 1 #

Patch Set 2 : Fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -6 lines) Patch
M LayoutTests/http/tests/inspector/network/load-resource-for-frontend-expected.txt View 2 chunks +2 lines, -1 line 0 comments Download
A LayoutTests/inspector/load-file-resource-for-frontend.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/inspector/load-file-resource-for-frontend-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/resources/file-resource-to-load-for-frontend.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
Please review
7 years, 4 months ago (2013-08-23 15:19:18 UTC) #1
pfeldman
lgtm
7 years, 4 months ago (2013-08-23 16:05:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/23102017/1
7 years, 4 months ago (2013-08-23 16:06:56 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=2993
7 years, 4 months ago (2013-08-23 17:24:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/23102017/18001
7 years, 4 months ago (2013-08-26 08:59:05 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-26 15:04:53 UTC) #6
Message was sent while issue was closed.
Change committed as 156706

Powered by Google App Engine
This is Rietveld 408576698