Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 23102010: Add gcapi to all.gyp. (Closed)

Created:
7 years, 4 months ago by gab
Modified:
7 years, 4 months ago
Reviewers:
robertshield
CC:
chromium-reviews, macourteau
Visibility:
Public.

Description

Add gcapi to all.gyp. Allowing for: 1) Running gcapi_test on the try bots. 2) Being able to extract gcapi_dll from real official builds (instead of shipping local dev builds...) 2.5) (2) Since gcapi_dll depends on base and other targets, it's realllly bad to be shipping local dev builds from trunk; we should really always be looking to merge GCAPI changes at least up to beta and take the DLL from the official builders. BUG=277657, 277064 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/all.gyp View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gab
Robert, PTAL. Thanks! Gab
7 years, 4 months ago (2013-08-22 16:46:23 UTC) #1
robertshield
lgtm
7 years, 4 months ago (2013-08-22 17:16:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/23102010/1
7 years, 4 months ago (2013-08-22 17:24:56 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 20:15:14 UTC) #4
Message was sent while issue was closed.
Change committed as 219090

Powered by Google App Engine
This is Rietveld 408576698