Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23101004: Make configurationForViewport match production code (Closed)

Created:
7 years, 4 months ago by rune
Modified:
7 years, 4 months ago
CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make configurationForViewport match production code While the production code has used initial viewport width and height for device-width and device-height, the configurationForViewport API in test builds still used separate values for the device size. This CL removes the redundant deviceSize in the production code and removes the device parameters from configurationForViewport so that the tests give the same results as the production code would do. BUG=273649 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156302

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renamed configurationForViewport to viewportAsText #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -443 lines) Patch
M LayoutTests/css3/device-adapt/opera/cascading-001.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/cascading-002.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/cascading-003.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/cascading-004.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-001.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-002.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-003.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-004.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-005.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-006.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-007.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-008.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-009.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-010.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-011.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-012.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-013.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-014.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-015.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-016.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-017.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-018.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-019.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/cssom-001.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-001.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-002.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-003.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-004.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-005.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-006.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-007.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/orientation-001.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/orientation-002.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/syntax-001.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/syntax-002.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/opera/syntax-003.html View 1 1 chunk +3 lines, -7 lines 0 comments Download
M LayoutTests/css3/device-adapt/viewport-height-extend-to-zoom.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/device-adapt/viewport-height-extend-to-zoom-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-initial-height-zero.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-initial-width-zero.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-insert-rule-after.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-insert-rule-before.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-min-width-extend-to-zoom.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/device-adapt/viewport-min-width-extend-to-zoom-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-relative-font.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-user-style.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/device-adapt/viewport-user-style-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-width-extend-to-zoom.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/device-adapt/viewport-width-extend-to-zoom-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-1.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-10.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-100.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-101.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-102.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-103.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-104.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-105.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-106.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-107.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-108.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-109.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-11.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-110.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-111.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-112.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-113.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-114.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-115.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-116.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-117.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-118.html View 1 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/viewport/viewport-119.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-12.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-120.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-121.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-122.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-123.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-124.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-125.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-126.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-127.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-129.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-13.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-130.html View 1 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/viewport/viewport-131.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-132.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-133.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-134.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-14.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-15.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-16.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-17.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-18.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-19.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-2.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-20.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-21.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-22.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-23.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-24.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-25.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-26.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-27.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-28.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-28-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-29.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-3.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-30.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-31.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-32.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-33.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-34.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-35.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-36.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-37.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-37-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-38.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-39.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-4.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-40.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-40-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-41.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-42.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-43.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-44.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-45.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-46.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-47.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-48.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-49.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-5.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-50.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-51.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-52.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-53.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-54.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-55.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-56.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-57.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-58.html View 1 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/viewport/viewport-59.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-6.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-60.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-61.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-62.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-63.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-64.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-65.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-66.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-67.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-68.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-69.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-7.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-70.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-71.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-72.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-73.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-74.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-75.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-76.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-77.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-78.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-79.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-8.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-80.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-81.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-82.html View 1 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/viewport/viewport-83.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-84.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-85.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-86.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-87.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-88.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-9.html View 1 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/viewport/viewport-90.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-handheldfriendly.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-mobileoptimized.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-mobileoptimized-2.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-mobileoptimized-3.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-ordering-1.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-ordering-2.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-ordering-3.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-ordering-4.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-ordering-5.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-ordering-6.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-ordering-7.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-ordering-8.html View 1 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/viewport/viewport-legacy-ordering-9.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-xhtmlmp.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-ordering.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-warnings-1.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-warnings-2.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-warnings-3.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-warnings-4.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-warnings-5.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/viewport/viewport-warnings-6.html View 1 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/ViewportArguments.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ViewportArguments.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/page/PageScaleConstraintsSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
7 years, 4 months ago (2013-08-15 11:33:06 UTC) #1
kenneth.r.christiansen
lgtm but I would rename configurationForViewport at the same time. I used to have a ...
7 years, 4 months ago (2013-08-15 18:36:35 UTC) #2
rune
https://codereview.chromium.org/23101004/diff/1/LayoutTests/css3/device-adapt/opera/constrain-008.html File LayoutTests/css3/device-adapt/opera/constrain-008.html (right): https://codereview.chromium.org/23101004/diff/1/LayoutTests/css3/device-adapt/opera/constrain-008.html#newcode55 LayoutTests/css3/device-adapt/opera/constrain-008.html:55: var vpString = internals.configurationForViewport(document, 1, On 2013/08/15 18:36:35, kenneth.r.christiansen ...
7 years, 4 months ago (2013-08-15 20:40:07 UTC) #3
kenneth.r.christiansen
lgtm!
7 years, 4 months ago (2013-08-15 21:23:48 UTC) #4
rune
7 years, 4 months ago (2013-08-19 07:12:57 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-19 08:44:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/23101004/6001
7 years, 4 months ago (2013-08-19 09:05:48 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 10:54:41 UTC) #8
Message was sent while issue was closed. 
Change committed as 156302

Powered by Google App Engine
This is Rietveld 408576698