Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 23095002: Make the MessageLoop PostTask ID more unique. (Closed)

Created:
7 years, 4 months ago by dsinclair
Modified:
7 years, 4 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Visibility:
Public.

Description

Make the MessageLoop PostTask ID more unique. When looking at chrome://tracing we were seeing duplicate IDs linking PostTask flow events. This CL is an attempt to fix that issue. Currently we take the sequence_num and shift it 32 bits to the left in a uint64. When then OR the intptr_t of this into that number. On x86_64 the sizeof(intptr_t) is 8bytes. This means, we'll be ORing the top 32 bits of the this address with the sequence_num. This CL takes the this pointer and removes the top 32bits before ORing with the sequence_num. So, we get the sequence_num followed by the bottom 32bits of the this pointer. BUG= TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/message_loop/message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
nduca
lgtm
7 years, 4 months ago (2013-08-13 18:01:18 UTC) #1
dsinclair
brettw PTAL for base/ OWNERS.
7 years, 4 months ago (2013-08-13 18:23:48 UTC) #2
dsinclair
darin for base/ OWNERS
7 years, 4 months ago (2013-08-14 19:08:27 UTC) #3
dsinclair
ping
7 years, 4 months ago (2013-08-16 14:43:32 UTC) #4
nduca
Lets TBR=darin this and I'll take responsibility if anyone flips. base/ OWNERS are hard to ...
7 years, 4 months ago (2013-08-17 01:19:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/23095002/1
7 years, 4 months ago (2013-08-17 02:41:26 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=78457
7 years, 4 months ago (2013-08-17 03:16:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/23095002/1
7 years, 4 months ago (2013-08-17 03:20:37 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=78464
7 years, 4 months ago (2013-08-17 03:44:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/23095002/1
7 years, 4 months ago (2013-08-17 16:52:54 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=78575
7 years, 4 months ago (2013-08-17 17:14:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/23095002/1
7 years, 4 months ago (2013-08-17 17:57:46 UTC) #12
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=78591
7 years, 4 months ago (2013-08-17 18:19:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/23095002/1
7 years, 4 months ago (2013-08-19 17:11:55 UTC) #14
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 01:49:39 UTC) #15
Message was sent while issue was closed.
Change committed as 218403

Powered by Google App Engine
This is Rietveld 408576698