Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: net/url_request/url_request_data_job_fuzzer.cc

Issue 2308443002: Make FuzzedDataProvider vend std::strings (Closed)
Patch Set: thestig review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/udp/fuzzed_datagram_client_socket.cc ('k') | net/websockets/websocket_deflate_stream_fuzzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_data_job_fuzzer.cc
diff --git a/net/url_request/url_request_data_job_fuzzer.cc b/net/url_request/url_request_data_job_fuzzer.cc
index 4c76e2cbd614071827da492e3fa51fe2cfba73e0..faed541973e21f434d760680198daadd12480521 100644
--- a/net/url_request/url_request_data_job_fuzzer.cc
+++ b/net/url_request/url_request_data_job_fuzzer.cc
@@ -54,7 +54,7 @@ class URLRequestDataJobFuzzerHarness : public net::URLRequest::Delegate {
// header in consistent byte addresses so the fuzzer doesn't have to work as
// hard.
bool use_range = provider.ConsumeBool();
- base::StringPiece range(provider.ConsumeBytes(kMaxLengthForFuzzedRange));
+ std::string range(provider.ConsumeBytes(kMaxLengthForFuzzedRange));
// Generate a sequence of reads sufficient to read the entire data URL.
size_t simulated_bytes_read = 0;
@@ -68,7 +68,7 @@ class URLRequestDataJobFuzzerHarness : public net::URLRequest::Delegate {
// ensure that if it's a URL, it's a data URL. If the URL is invalid just
// use a test variant, so the fuzzer has a chance to execute something.
std::string data_url_string =
- std::string("data:") + provider.ConsumeRemainingBytes().as_string();
+ std::string("data:") + provider.ConsumeRemainingBytes();
GURL data_url(data_url_string);
if (!data_url.is_valid())
data_url = GURL("data:text/html;charset=utf-8,<p>test</p>");
@@ -78,10 +78,9 @@ class URLRequestDataJobFuzzerHarness : public net::URLRequest::Delegate {
std::unique_ptr<net::URLRequest> request =
context_.CreateRequest(data_url, net::DEFAULT_PRIORITY, this);
if (use_range) {
- std::string range_str = range.as_string();
- if (!net::HttpUtil::IsValidHeaderValue(range_str))
- range_str = "bytes=3-";
- request->SetExtraRequestHeaderByName("Range", range_str, true);
+ if (!net::HttpUtil::IsValidHeaderValue(range))
+ range = "bytes=3-";
+ request->SetExtraRequestHeaderByName("Range", range, true);
}
// Block the thread while the request is read.
« no previous file with comments | « net/udp/fuzzed_datagram_client_socket.cc ('k') | net/websockets/websocket_deflate_stream_fuzzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698