Make FuzzedDataProvider vend std::strings

Make FuzzedDataProvider vend std::strings

This patch also updates all consumers to use the new API.

This will help ASAN catch a broader class of problems in terms of accessing
data outside of the returned buffer.

BUG=639827
Committed: https://crrev.com/987cf79c0d88104a3d491760b1b3b3294bb1d80a
Cr-Commit-Position: refs/heads/master@{#426310}

[Charlie Harrison, 2016-09-02 03:27:22]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 03:27:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 03:39:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 03:39:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie Harrison, 2016-09-02 03:50:34]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 03:51:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 04:30:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 04:30:10]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Charlie Harrison, 2016-09-02 12:27:51]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 12:28:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-09-02 13:19:46]

csharrison@chromium.org changed reviewers:
+ mmenke@chromium.org

[Charlie Harrison, 2016-09-02 13:19:46]

mmenke, would you take a first pass at this? Low priority.

[commit-bot: I haz the power, 2016-09-02 14:02:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 14:02:48]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-09-02 20:04:46]

On 2016/09/02 13:19:46, Charlie Harrison wrote:
> mmenke, would you take a first pass at this? Low priority.

Let's hold off until the thread on platform-architecture-dev resumes.

[Charlie Harrison, 2016-10-19 16:55:40]

Description was changed from

==========
Make FuzzedDataProvider header-only and vend std::strings

This patch also updates all consumers to use the new API.

BUG=639827
==========

to

==========
Make FuzzedDataProvider header-only and vend std::strings

This patch also updates all consumers to use the new API.

This will help ASAN catch a broader class of problems in terms of accessing
data outside of the returned buffer.


BUG=639827
==========

[Charlie Harrison, 2016-10-19 17:00:10]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 17:00:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-10-19 17:01:57]

PTAL, this implementation is no longer header-only, per discussion on
platform-architecture-dev.

[Charlie Harrison, 2016-10-19 17:02:24]

Description was changed from

==========
Make FuzzedDataProvider header-only and vend std::strings

This patch also updates all consumers to use the new API.

This will help ASAN catch a broader class of problems in terms of accessing
data outside of the returned buffer.


BUG=639827
==========

to

==========
Make FuzzedDataProvider vend std::strings

This patch also updates all consumers to use the new API.

This will help ASAN catch a broader class of problems in terms of accessing
data outside of the returned buffer.


BUG=639827
==========

[mmenke, 2016-10-19 17:44:49]

LGTM!

[Charlie Harrison, 2016-10-19 17:46:30]

csharrison@chromium.org changed reviewers:
+ thestig@chromium.org

[Charlie Harrison, 2016-10-19 17:46:30]

Thanks!

+thestig for base and third_party. I got a presubmit about changes to sfntly
needing to update README.chromium. Is that necessary for this fuzzer change?

[Charlie Harrison, 2016-10-19 17:48:17]

csharrison@chromium.org changed reviewers:
+ haraken@chromium.org

[Charlie Harrison, 2016-10-19 17:48:18]

Oh, and +haraken for the small change to blink.

[Lei Zhang, 2016-10-19 17:49:49]

lgtm

Can you re-upload? base/test/fuzzed_data_provider.cc strangely shows up as 'D'
when it should be 'M'.

https://chromiumcodereview.appspot.com/2308443002/diff/60001/base/test/fuzzed...
File base/test/fuzzed_data_provider.h (right):

https://chromiumcodereview.appspot.com/2308443002/diff/60001/base/test/fuzzed...
base/test/fuzzed_data_provider.h:9: #include <string>
nit: Chromium style still likes to have a separator between C and C++ headers.

[haraken, 2016-10-19 18:00:15]

WebKit LGTM

[Charlie Harrison, 2016-10-19 18:00:56]

Thanks all!

thestig: looks like we're still getting a "D" after another git cl upload :/

https://chromiumcodereview.appspot.com/2308443002/diff/60001/base/test/fuzzed...
File base/test/fuzzed_data_provider.h (right):

https://chromiumcodereview.appspot.com/2308443002/diff/60001/base/test/fuzzed...
base/test/fuzzed_data_provider.h:9: #include <string>
On 2016/10/19 17:49:49, Lei Zhang wrote:
> nit: Chromium style still likes to have a separator between C and C++ headers.

Done.

[Charlie Harrison, 2016-10-19 18:35:27]

cc mmoroz FYI as this could regress performance slightly for these fuzzers. I
will try to keep an eye on the dashboards though. Local testing did not show
anything significant.

Proceeding with land.

[Charlie Harrison, 2016-10-19 18:35:33]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-10-19 18:35:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2308443002/#ps80001
(title: "thestig review")

[commit-bot: I haz the power, 2016-10-19 18:36:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 20:34:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 20:34:16]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Charlie Harrison, 2016-10-19 20:35:01]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-10-19 20:35:09]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-10-19 20:35:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 22:37:35]

Description was changed from

==========
Make FuzzedDataProvider vend std::strings

This patch also updates all consumers to use the new API.

This will help ASAN catch a broader class of problems in terms of accessing
data outside of the returned buffer.


BUG=639827
==========

to

==========
Make FuzzedDataProvider vend std::strings

This patch also updates all consumers to use the new API.

This will help ASAN catch a broader class of problems in terms of accessing
data outside of the returned buffer.


BUG=639827
==========

[commit-bot: I haz the power, 2016-10-19 22:37:37]

Committed patchset #5 (id:80001)

[mmoroz, 2016-10-20 09:02:33]

Description was changed from

==========
Make FuzzedDataProvider vend std::strings

This patch also updates all consumers to use the new API.

This will help ASAN catch a broader class of problems in terms of accessing
data outside of the returned buffer.


BUG=639827
==========

to

==========
Make FuzzedDataProvider vend std::strings

This patch also updates all consumers to use the new API.

This will help ASAN catch a broader class of problems in terms of accessing
data outside of the returned buffer.


BUG=639827
==========

[mmoroz, 2016-10-20 09:03:20]

On 2016/10/19 18:35:27, Charlie Harrison wrote:
> cc mmoroz FYI as this could regress performance slightly for these fuzzers. I
> will try to keep an eye on the dashboards though. Local testing did not show
> anything significant.
> 
> Proceeding with land.

Thanks for the heads up!

[commit-bot: I haz the power, 2016-10-21 13:12:21]

Description was changed from

==========
Make FuzzedDataProvider vend std::strings

This patch also updates all consumers to use the new API.

This will help ASAN catch a broader class of problems in terms of accessing
data outside of the returned buffer.


BUG=639827
==========

to

==========
Make FuzzedDataProvider vend std::strings

This patch also updates all consumers to use the new API.

This will help ASAN catch a broader class of problems in terms of accessing
data outside of the returned buffer.

BUG=639827

Committed: https://crrev.com/987cf79c0d88104a3d491760b1b3b3294bb1d80a
Cr-Commit-Position: refs/heads/master@{#426310}
==========

[commit-bot: I haz the power, 2016-10-21 13:12:22]

Patchset 5 (id:??) landed as
https://crrev.com/987cf79c0d88104a3d491760b1b3b3294bb1d80a
Cr-Commit-Position: refs/heads/master@{#426310}