Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 23084002: Use the outermost float for shape-outside (Closed)

Created:
7 years, 4 months ago by Bem Jones-Bey (adobe)
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Use the outermost float for shape-outside Shape outside was using the last float encountered on the line, assuming it would always be the outermost float. However, this is not necessarily true, so switch to using the outermost float. This has the advantage of also only needing one saved float when computing the offset, not two. BUG=271774 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156038

Patch Set 1 #

Patch Set 2 : Added tests #

Patch Set 3 : Update test #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -19 lines) Patch
A LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-outermost.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-outermost-expected.html View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 3 3 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bem Jones-Bey (adobe)
More float code cleanup, but this has a minor behavior change for shape-outside.
7 years, 4 months ago (2013-08-13 17:16:43 UTC) #1
eseidel
lgtm Are we going to change the spec too? :)
7 years, 4 months ago (2013-08-13 17:36:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/23084002/9001
7 years, 4 months ago (2013-08-13 17:36:54 UTC) #3
Bem Jones-Bey (adobe)
On 2013/08/13 17:36:38, eseidel wrote: > lgtm > > Are we going to change the ...
7 years, 4 months ago (2013-08-13 17:42:07 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 18:48:24 UTC) #5
Message was sent while issue was closed.
Change committed as 156038

Powered by Google App Engine
This is Rietveld 408576698