Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 23081003: Docserver move cron jobs to a backend instance

Created:
7 years, 4 months ago by jshumway
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Docserver move cron jobs to a backend instance backends.yaml now specifies a 'worker' backend that will sync with src.chromium.org and render all the pages. cron.yaml now targets 'worker', which may or may not actually work. There isn't documentation on this, see [1], but setting target to the backend name *should* work. It didn't seem to work on the dev server though. Removed the logic in cron_servlet.py that dealt with DeadlineExceededError. [1] https://code.google.com/p/googleappengine/issues/detail?id=6301 BUG=270808

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -95 lines) Patch
M chrome/common/extensions/docs/server2/PRESUBMIT.py View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/common/extensions/docs/server2/appengine_wrappers.py View 1 chunk +6 lines, -2 lines 1 comment Download
A chrome/common/extensions/docs/server2/backends.yaml View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron_servlet.py View 4 chunks +48 lines, -70 lines 1 comment Download
M chrome/common/extensions/docs/server2/handler.py View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/start_dev_server.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jshumway
7 years, 4 months ago (2013-08-13 18:43:09 UTC) #1
方觉(Fang Jue)
7 years, 4 months ago (2013-08-14 01:47:42 UTC) #2
https://codereview.chromium.org/23081003/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/server2/appengine_wrappers.py (right):

https://codereview.chromium.org/23081003/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/server2/appengine_wrappers.py:13: #
backend_name:2-0-25.23982345. We only want the 2-0-25.
Backend's version ID will look like <backend-name>.123456. A backend is actually
a separate version of the app (which means that update_server.py also needs to
be updated to also deploy the backend). Maybe include the current version number
in the backend name or pass it in /_cron/ URL?

https://codereview.chromium.org/23081003/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/server2/cron_servlet.py (left):

https://codereview.chromium.org/23081003/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/server2/cron_servlet.py:11: GetAppVersion,
DeadlineExceededError, IsDevServer, logservice)
DeadlineExceededError can still happen even if it's a backend and there're more
than one type of DeadlineExceededError. See
https://codereview.chromium.org/22457003/diff/22001/chrome/common/extensions/....

Powered by Google App Engine
This is Rietveld 408576698