Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 23081002: Revert "Correct bit-shift in IPC hash generation." (Closed)

Created:
7 years, 4 months ago by dsinclair
Modified:
7 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert "Correct bit-shift in IPC hash generation." This reverts commit r213882. This change caused too much shifting. Reverting back to the original as it is, in fact, correct. BUG= TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ipc/ipc_message.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dsinclair
nduca, PTAL.
7 years, 4 months ago (2013-08-13 16:44:22 UTC) #1
nduca
lgtm
7 years, 4 months ago (2013-08-13 19:17:07 UTC) #2
dsinclair
cpu for ipc/ OWNERS.
7 years, 4 months ago (2013-08-13 20:16:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/23081002/1
7 years, 4 months ago (2013-08-13 21:20:20 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 00:37:50 UTC) #5
Message was sent while issue was closed.
Change committed as 217408

Powered by Google App Engine
This is Rietveld 408576698