native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc - Issue 23075013: [NaCl SDK] Enable select/poll on TTY nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

Issue 23075013: [NaCl SDK] Enable select/poll on TTY nodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

index b45bf268354c592e214625d06e91b629713715c6..1a0542c12d62f23628ee7add15ff3fe39c094aab 100644

--- a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

+++ b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

@@ -791,7 +791,7 @@ int KernelProxy::select(int nfds, fd_set* readfds, fd_set* writefds,

// If the timeout is invalid or too long (larger than signed 32 bit).

if ((timeout->tv_sec < 0) || (timeout->tv_sec >= (INT_MAX / 1000)) ||

- (timeout->tv_usec < 0) || (timeout->tv_usec >= 1000) ||

+ (timeout->tv_usec < 0) || (timeout->tv_usec >= 1000000) ||

(ms < 0) || (ms >= INT_MAX)) {

errno = EINVAL;

return -1;