Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 23075007: Android: uses BUILDTYPE rather than CHROMIUM_BUILD_TYPE. (Closed)

Created:
7 years, 4 months ago by bulach
Modified:
7 years, 4 months ago
Reviewers:
craigdh, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android: uses BUILDTYPE rather than CHROMIUM_BUILD_TYPE. Buildbot and other platforms use BUILDTYPE. BUG=260494 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/pylib/constants.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
ptal
7 years, 4 months ago (2013-08-16 09:15:05 UTC) #1
craigdh
So this was actually intentional to not interfere with uses of BUILDTYPE, but if you ...
7 years, 4 months ago (2013-08-16 15:59:54 UTC) #2
bulach
hmm, I think it'd be less confusing to have just one var all over the ...
7 years, 4 months ago (2013-08-16 16:01:32 UTC) #3
craigdh
On 2013/08/16 16:01:32, bulach wrote: > hmm, I think it'd be less confusing to have ...
7 years, 4 months ago (2013-08-16 16:02:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/23075007/1
7 years, 4 months ago (2013-08-16 16:44:13 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 20:37:06 UTC) #6
Message was sent while issue was closed.
Change committed as 218078

Powered by Google App Engine
This is Rietveld 408576698