src/x64/lithium-codegen-x64.cc - Issue 23074003: Load size in signed int before making negative.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 23074003: Load size in signed int before making negative. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix FPU stack in CmpHole Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 42c23dbfb7137d08f2b0d1043162f234b01ffae3..abb8c77b5b772cd0440251034944771b8277abd9 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -2196,9 +2196,8 @@ void LCodeGen::DoCmpHoleAndBranch(LCmpHoleAndBranch* instr) {

__ movsd(MemOperand(rsp, 0), input_reg);

__ addq(rsp, Immediate(kDoubleSize));

- int size = sizeof(kHoleNanUpper32);

- __ cmpl(MemOperand(rsp, -size),

- Immediate(kHoleNanUpper32));

+ int offset = sizeof(kHoleNanUpper32);

+ __ cmpl(MemOperand(rsp, -offset), Immediate(kHoleNanUpper32));

EmitBranch(instr, equal);

}

« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | no next file » | no next file with comments »