Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 23074003: Load size in signed int before making negative. (Closed)

Created:
7 years, 4 months ago by Toon Verwaest
Modified:
7 years, 4 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Load size in signed int before making negative. R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16184

Patch Set 1 #

Patch Set 2 : Fix FPU stack in CmpHole #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/ia32/lithium-codegen-ia32.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 4 months ago (2013-08-14 09:02:51 UTC) #1
danno
lgtm
7 years, 4 months ago (2013-08-14 09:47:00 UTC) #2
Toon Verwaest
7 years, 4 months ago (2013-08-14 09:47:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16184.

Powered by Google App Engine
This is Rietveld 408576698