Issue 23072022: [pkg:web_ui] fix insertBefore case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23072022: [pkg:web_ui] fix insertBefore case (Closed)

Created:
7 years, 4 months ago by Jennifer Messerly

Modified:
7 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/web-ui.git@master

Visibility:
Public.

fix insertBefore case this was failing with noSuchMethod because insertBefore is on Node and not NodeList. R=sigmund@google.com Committed: https://github.com/dart-lang/web-ui/commit/aec0e52

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	lib/src/emitters.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Jennifer Messerly

7 years, 4 months ago (2013-08-19 22:16:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as raec0e52 (presubmit successful).