Chromium Code Reviews
Help | Chromium Project | Sign in
(41)

Issue 23072022: [pkg:web_ui] fix insertBefore case (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by John Messerly
Modified:
1 year, 8 months ago
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/web-ui.git@master
Visibility:
Public.

Description

fix insertBefore case this was failing with noSuchMethod because insertBefore is on Node and not NodeList. R=sigmund@google.com Committed: https://github.com/dart-lang/web-ui/commit/aec0e52

Patch Set 1 #

Patch Set 2 : also change pubspec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/src/emitters.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
John Messerly
1 year, 8 months ago (2013-08-19 22:13:52 UTC) #1
Siggi Cherem (dart-lang)
lgtm Thanks John
1 year, 8 months ago (2013-08-19 22:15:09 UTC) #2
John Messerly
1 year, 8 months ago (2013-08-19 22:16:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as raec0e52 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771