Chromium Code Reviews
Help | Chromium Project | Sign in

Issue 23072022: [pkg:web_ui] fix insertBefore case (Closed)

Can't Edit
Can't Publish+Mail
Start Review
3 years ago by John Messerly
3 years ago
Base URL:


fix insertBefore case this was failing with noSuchMethod because insertBefore is on Node and not NodeList. Committed:

Patch Set 1 #

Patch Set 2 : also change pubspec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/src/emitters.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).


Total messages: 3 (0 generated)
John Messerly
3 years ago (2013-08-19 22:13:52 UTC) #1
Siggi Cherem (dart-lang)
lgtm Thanks John
3 years ago (2013-08-19 22:15:09 UTC) #2
John Messerly
3 years ago (2013-08-19 22:16:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as raec0e52 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e15fb99