Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 23071004: AccessibilityController::reset() should reset all notification listener callbacks. (Closed)

Created:
7 years, 4 months ago by kouhei (in TOK)
Modified:
7 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, dmazzoni, eae+blinkwatch, aboxhall
Visibility:
Public.

Description

AccessibilityController::reset() should reset all notification listener callbacks. BUG=270000 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
A + LayoutTests/accessibility/accessibility-controller-notificationlistener-leak-callback.html View 1 chunk +2 lines, -10 lines 0 comments Download
A + LayoutTests/accessibility/accessibility-controller-notificationlistener-leak-callback-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/testing/runner/AccessibilityControllerChromium.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kouhei (in TOK)
haraken: r?
7 years, 4 months ago (2013-08-22 04:39:49 UTC) #1
kouhei (in TOK)
haraken: r?
7 years, 4 months ago (2013-08-22 04:39:49 UTC) #2
haraken
LGTM
7 years, 4 months ago (2013-08-22 04:42:27 UTC) #3
kouhei (in TOK)
Thanks for the review!
7 years, 4 months ago (2013-08-22 04:43:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/23071004/1
7 years, 4 months ago (2013-08-22 04:43:52 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-22 04:54:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/23071004/1
7 years, 4 months ago (2013-08-22 04:57:31 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 06:36:04 UTC) #8
Message was sent while issue was closed.
Change committed as 156547

Powered by Google App Engine
This is Rietveld 408576698