chrome/browser/metrics/variations/variations_http_header_provider.cc - Issue 23064011: Consolidate scheme checks into an easy GURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/variations_http_header_provider.cc

Issue 23064011: Consolidate scheme checks into an easy GURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/variations/variations_http_header_provider.cc

diff --git a/chrome/browser/metrics/variations/variations_http_header_provider.cc b/chrome/browser/metrics/variations/variations_http_header_provider.cc

index f4ed100d80cb563222980d303360e920570d2207..7be3775221011024c4e15b1505e3d84509bafe81 100644

--- a/chrome/browser/metrics/variations/variations_http_header_provider.cc

+++ b/chrome/browser/metrics/variations/variations_http_header_provider.cc

@@ -156,7 +156,7 @@ bool VariationsHttpHeaderProvider::ShouldAppendHeaders(const GURL& url) {

}

// The below mirrors logic in IsGoogleDomainUrl(), but for youtube.<TLD>.

- if (!url.is_valid() || !(url.SchemeIs("http") || url.SchemeIs("https")))

+ if (!url.is_valid() || !url.SchemeIsHTTPOrHTTPS())

return false;

const std::string host = url.host();

« no previous file with comments | « chrome/browser/google/google_util.cc ('k') | chrome/browser/net/predictor.cc » ('j') | no next file with comments »