chrome/browser/extensions/api/dial/dial_device_data.cc - Issue 23064011: Consolidate scheme checks into an easy GURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/dial/dial_device_data.cc

Issue 23064011: Consolidate scheme checks into an easy GURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/dial/dial_device_data.cc

diff --git a/chrome/browser/extensions/api/dial/dial_device_data.cc b/chrome/browser/extensions/api/dial/dial_device_data.cc

index 125317d70a5f73a9019c2a8fb11675d632ec126c..f8f5540485e68f845b30f6c2c3e8df254dc4b1ec 100644

--- a/chrome/browser/extensions/api/dial/dial_device_data.cc

+++ b/chrome/browser/extensions/api/dial/dial_device_data.cc

@@ -29,8 +29,7 @@ void DialDeviceData::set_device_description_url(const GURL& url) {

// static

bool DialDeviceData::IsDeviceDescriptionUrl(const GURL& url) {

- return url.is_valid() && !url.is_empty() &&

- (url.SchemeIs("http") || url.SchemeIs("https"));

+ return url.is_valid() && !url.is_empty() && url.SchemeIsHTTPOrHTTPS();

}

bool DialDeviceData::UpdateFrom(const DialDeviceData& new_data) {