Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 23064007: Android WebView: build fixes for use_system_skia. (Closed)

Created:
7 years, 4 months ago by Torne
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android WebView: build fixes for use_system_skia. The skia shim headers were not being included at the front of the path because of a gyp processing issue, causing it to pick up the bundled headers instead by mistake; fix the gyp file. Also, some of the chromium code depends on non-public headers; add the required include path for this to work until we can fix the code. BUG=263818, 274425 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M build/shim_headers.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M skia/skia_system.gypi View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Torne
Hi Derek, Robert (also martin for committer), This is the one remaining patch to make ...
7 years, 4 months ago (2013-08-16 13:07:54 UTC) #1
robertphillips
lgtm
7 years, 4 months ago (2013-08-16 13:10:13 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 4 months ago (2013-08-16 13:14:22 UTC) #3
mkosiba (inactive)
lgtm
7 years, 4 months ago (2013-08-16 13:23:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/23064007/1
7 years, 4 months ago (2013-08-16 13:23:21 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 15:28:09 UTC) #6
Message was sent while issue was closed.
Change committed as 218021

Powered by Google App Engine
This is Rietveld 408576698