Issue 23061006: [Telemetry] Bypass proxies in Chrome and on the host machine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23061006: [Telemetry] Bypass proxies in Chrome and on the host machine. (Closed)

Created:
7 years, 4 months ago by James Simonsen

Modified:
7 years, 4 months ago

Reviewers:
dtu, tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Bypass proxies in Chrome and on the host machine. These caused all sorts of problems when I tried to run on a borrowed XP machine. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218901

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tonyg

lgtm Thanks for fixing this. You've saved someone else an afternoon of frustration. https://codereview.chromium.org/23061006/diff/1/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py File ...

7 years, 4 months ago (2013-08-21 22:51:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonjam@chromium.org/23061006/6001

7 years, 4 months ago (2013-08-21 23:21:50 UTC) #4

Message was sent while issue was closed.

Change committed as 218901

Expand Messages | Collapse Messages