Make the perf bots dump symbols.

Make the perf bots dump symbols.

I recently switched the perf bots to use official builds on linux. However,
my first pass resulted in no breakpad syms.

In this change, making the perf bots build the linux_symbols
target so that breakpad symbols will be available to minidump_stackwalk when
a perf test crashes.

BUG=223572, 271252
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219611

[Lei Zhang, 2013-08-26 05:23:04]

You can strip the symbols for your builder(s) to save space, but please don't
make it the default setting for everyone. For instance, developers occasionally
need to make 'official' builds and still run it in the debugger.

[tonyg, 2013-08-26 16:26:04]

On 2013/08/26 05:23:04, Lei Zhang wrote:
> You can strip the symbols for your builder(s) to save space, but please don't
> make it the default setting for everyone. For instance, developers
occasionally
> need to make 'official' builds and still run it in the debugger.

My rationale is that when a developer does an official build, their intent is to
build the actual bits that we ship. I can change our builder to set
linux_strip_binary, but then when a developer goes to test something on an
official build, they can easily be tricked into testing a build that is double
the size of what we actually ship.

Here's the difference in startup time of a stripped vs symbol build:
https://chromeperf.appspot.com/report?rev=219369&masters=ChromiumPerf&bots=li...

My preference is to avoid this potential confusion for developers. But if you
disagree, I'll defer to you and just set this flag on the builders.

It doesn't look like I can override it on a per-target basis, so I've
provisionally reverted that part from the CL and will make a follow up in the
master.cfg file.

[Lei Zhang, 2013-08-26 16:58:08]

On 2013/08/26 16:26:04, tonyg wrote:
> On 2013/08/26 05:23:04, Lei Zhang wrote:
> > You can strip the symbols for your builder(s) to save space, but please
don't
> > make it the default setting for everyone. For instance, developers
> occasionally
> > need to make 'official' builds and still run it in the debugger.
> 
> My rationale is that when a developer does an official build, their intent is
to
> build the actual bits that we ship. I can change our builder to set
> linux_strip_binary, but then when a developer goes to test something on an
> official build, they can easily be tricked into testing a build that is double
> the size of what we actually ship.
> 
> Here's the difference in startup time of a stripped vs symbol build:
>
https://chromeperf.appspot.com/report?rev=219369&masters=ChromiumPerf&bots=li...
> 
> My preference is to avoid this potential confusion for developers. But if you
> disagree, I'll defer to you and just set this flag on the builders.
> 
> It doesn't look like I can override it on a per-target basis, so I've
> provisionally reverted that part from the CL and will make a follow up in the
> master.cfg file.

Patch set 2 lgtm.

Links doesn't seem to work for me, but I believe you. Yes, there are times when
developers need to test browser start up time and stripping the binary gets you
more accurate start up time. But more often a developer needs a build to debug
something. They can always strip it later if they need to test start up time.

The debugging symbols being stripped out contains more useful data than the
Breakpad symbols files. Thus we also archive it for official builds in a
post-build step. Doing it here would break that build step.

[commit-bot: I haz the power, 2013-08-26 17:03:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tonyg@chromium.org/23060042/12001

[commit-bot: I haz the power, 2013-08-26 21:07:23]

Change committed as 219611