Issue 23060037: IndexedDB: Return refs from a few const property accessors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23060037: IndexedDB: Return refs from a few const property accessors (Closed)

Created:
7 years, 4 months ago by jsbell

Modified:
7 years, 3 months ago

Reviewers:
alecflett

CC:
blink-reviews, dgrogan, eae+blinkwatch, dglazkov+blink, alecflett

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IndexedDB: Return refs from a few const property accessors R=alecflett@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156659

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	Source/modules/indexeddb/IDBDatabase.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/modules/indexeddb/IDBIndex.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/indexeddb/IDBObjectStore.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jsbell

I noticed these while doing instrumented profiling runs. The metadata copies showed up as a ...

7 years, 4 months ago (2013-08-23 18:01:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/23060037/1

7 years, 4 months ago (2013-08-23 20:05:30 UTC) #3

jsbell

7 years, 3 months ago (2013-09-05 21:18:04 UTC) #5

Message was sent while issue was closed.

On 2013/08/23 21:56:59, I haz the power (commit-bot) wrote:
> Change committed as 156659

Probably a coincidence, but:

http://build.chromium.org/f/chromium/perf/linux-release/idb_perf/report.html?...

http://build.chromium.org/f/chromium/perf/chromium-rel-win7-dual/idb_perf/rep...

Expand Messages | Collapse Messages