LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html - Issue 23060031: Set <dialog> width and height to 'fit-content'.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html

Issue 23060031: Set <dialog> width and height to 'fit-content'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: give dialog height auto for dialog-autoheight test Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <style>	4 <style>

5 /* Remove margin, border, and padding to allow comparing dialog's position with that of plain span elements. */	5 /* Remove body margin and dialog styles to allow comparing dialog's position wit h that of plain span elements. */

6 body {	6 body {

7 margin: 0;	7 margin: 0;

8 }	8 }

9	9

10 dialog {	10 dialog {

11 border: 0;	11 border: 0;

12 padding: 0;	12 padding: 0;

	13 height: auto;

	14 width: auto;

13 }	15 }

14	16

15 .filler {	17 .filler {

16 height: 20000px;	18 height: 20000px;

17 }	19 }

18	20

19 </style>	21 </style>

20 <script src="../../js/resources/js-test-pre.js"></script>	22 <script src="../../js/resources/js-test-pre.js"></script>

21 <script>	23 <script>

22 function checkTopOfViewport(dialog) {	24 function checkTopOfViewport(dialog) {

(...skipping 168 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
191 dialog.style.position = 'relative';	193 dialog.style.position = 'relative';

192 dialog.style.top = '50px';	194 dialog.style.top = '50px';

193 // Just test non-modal since modal is covered by other tests (for modal, relativ e computes to absolute)	195 // Just test non-modal since modal is covered by other tests (for modal, relativ e computes to absolute)

194 dialog.show();	196 dialog.show();

195 shouldBe('dialog.getBoundingClientRect().top', 'expectedTop');	197 shouldBe('dialog.getBoundingClientRect().top', 'expectedTop');

196 dialog.close();	198 dialog.close();

197 </script>	199 </script>

198 <script src="../../js/resources/js-test-post.js"></script>	200 <script src="../../js/resources/js-test-post.js"></script>

199 </body>	201 </body>

200 </html>	202 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/dialog/top-layer-stacking-expected.html ('k') | LayoutTests/fast/regions/dialog-autoheight.html » ('j') | no next file with comments »