Fix namespace for AsyncSocketIoHandler.

Fix namespace for AsyncSocketIoHandler.

R=tommi@chromium.org
TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219286

[tommi (sloooow) - chröme, 2013-08-23 09:50:30]

lgtm

sorry, I should have caught that in the previous review.

[qsr, 2013-08-23 09:53:08]

+darin as TBR for ownership

[commit-bot: I haz the power, 2013-08-23 09:57:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/23058010/1

[commit-bot: I haz the power, 2013-08-23 13:26:33]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-08-23 13:46:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/23058010/1

[commit-bot: I haz the power, 2013-08-23 15:56:36]

Change committed as 219286

[darin (slow to review), 2013-08-23 16:20:41]

LGTM for the namespace change.

https://codereview.chromium.org/23058010/diff/1/base/async_socket_io_handler.h
File base/async_socket_io_handler.h (right):

https://codereview.chromium.org/23058010/diff/1/base/async_socket_io_handler....
base/async_socket_io_handler.h:16: typedef base::MessageLoopForIO::IOHandler
MessageLoopIOHandler;
nit: This appears to be defined in the wrong place. I would expect a top-level
typename that starts with MessageLoop to be defined in base/message_loop/
somewhere.

[qsr, 2013-08-26 08:36:02]

https://codereview.chromium.org/23058010/diff/1/base/async_socket_io_handler.h
File base/async_socket_io_handler.h (right):

https://codereview.chromium.org/23058010/diff/1/base/async_socket_io_handler....
base/async_socket_io_handler.h:16: typedef base::MessageLoopForIO::IOHandler
MessageLoopIOHandler;
 I'm not sure we want this to be available outside of this class...

 Would putting this in a async_socket_io_handler_internal sub-namespace be fine
with you?

[tommi (sloooow) - chröme, 2013-08-26 08:46:24]

https://codereview.chromium.org/23058010/diff/1/base/async_socket_io_handler.h
File base/async_socket_io_handler.h (right):

https://codereview.chromium.org/23058010/diff/1/base/async_socket_io_handler....
base/async_socket_io_handler.h:16: typedef base::MessageLoopForIO::IOHandler
MessageLoopIOHandler;
On 2013/08/26 08:36:02, qsr wrote:
>  I'm not sure we want this to be available outside of this class...
> 
>  Would putting this in a async_socket_io_handler_internal sub-namespace be
fine
> with you?

The IOHandler and Watcher interfaces actually are defined in message_loop/.  The
problem is that these interfaces have different names on Windows and Posix so an
#ifdef is needed here.
For slightly better readability (imho), I kept the #ifdef out of the class
inheritance section but you can just change that.  I.e. remove this typedef,
move the #ifdef into the inheritance section and problem solved.