Moved chrome/common/policy to components/policy.

Moved chrome/common/policy to components/policy.

This change also introduces //components/policy as a new layered component.
Some of the chrome/browser/policy code is being prepared to be moved into this
component.

This CL depends on https://codereview.chromium.org/22807004/.

BUG=271392
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217552

[Joao da Silva, 2013-08-13 12:07:30]

Please have a look:

@ Mattias: the whole shebang

@ Jói: the new component

@ Jochen: changes in chrome/

Thanks!

[Jói, 2013-08-13 12:26:43]

//components LGTM with a nit.

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi
File components/policy.gypi (right):

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi#newcode25
components/policy.gypi:25: 'policy/core/common/policy_schema.cc',
Maybe list policy_export.h for completeness.

[Mattias Nissler (ping if slow), 2013-08-13 12:32:08]

Mostly good, but I'd like to get an answer to the directory layout first before
I stamp.

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi
File components/policy.gypi (right):

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi#newcode21
components/policy.gypi:21: # but later it will include some stubs when
configuration_policy==0.
This comment may bitrot. So remove it or, if you want to keep it, please turn it
into a TODO with proper bug reference.

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi#newcode25
components/policy.gypi:25: 'policy/core/common/policy_schema.cc',
What's the plan with this 'core' directory? Can you give me background on the
high-level plan where files end up (and ideally document that on the bug)?

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi#newcode28
components/policy.gypi:28: } ],
nit }], seems to be more common in gyp files

[Joao da Silva, 2013-08-13 12:50:18]

PTAL

The android issues come from the parent CL, which needs to update the isolate
files. I'll figure what's wrong with the iOS build.

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi
File components/policy.gypi (right):

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi#newcode21
components/policy.gypi:21: # but later it will include some stubs when
configuration_policy==0.
On 2013/08/13 12:32:09, Mattias Nissler wrote:
> This comment may bitrot. So remove it or, if you want to keep it, please turn
it
> into a TODO with proper bug reference.

Done.

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi#newcode25
components/policy.gypi:25: 'policy/core/common/policy_schema.cc',
On 2013/08/13 12:26:43, Jói wrote:
> Maybe list policy_export.h for completeness.

Good catch, that was a lapse from my side. Done.

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi#newcode25
components/policy.gypi:25: 'policy/core/common/policy_schema.cc',
On 2013/08/13 12:32:09, Mattias Nissler wrote:
> What's the plan with this 'core' directory? Can you give me background on the
> high-level plan where files end up (and ideally document that on the bug)?

http://dev.chromium.org/developers/design-documents/structure-of-layered-comp...

I'm following the structure of the autofill component (see link below, slightly
out-of-date re structure). The core/ directory is further split into browser/
(not done in this CL yet) and common/, so that chrome/common/DEPS can whitelist
common/ only.

There's a lot more on the wiki:

http://dev.chromium.org/developers/design-documents/layered-components-techni...

http://dev.chromium.org/developers/design-documents/browser-components/cookbo...

http://dev.chromium.org/developers/design-documents/layered-components-design

http://dev.chromium.org/developers/design-documents/layered-components-techni...

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi#newcode28
components/policy.gypi:28: } ],
On 2013/08/13 12:32:09, Mattias Nissler wrote:
> nit }], seems to be more common in gyp files

Done.

[Mattias Nissler (ping if slow), 2013-08-13 13:14:38]

LGTM pending the bug update with a plan-of-action.

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi
File components/policy.gypi (right):

https://codereview.chromium.org/23045003/diff/1/components/policy.gypi#newcode25
components/policy.gypi:25: 'policy/core/common/policy_schema.cc',
On 2013/08/13 12:50:18, Joao da Silva wrote:
> On 2013/08/13 12:32:09, Mattias Nissler wrote:
> > What's the plan with this 'core' directory? Can you give me background on
the
> > high-level plan where files end up (and ideally document that on the bug)?
> 
>
http://dev.chromium.org/developers/design-documents/structure-of-layered-comp...
> 
> I'm following the structure of the autofill component (see link below,
slightly
> out-of-date re structure). The core/ directory is further split into browser/
> (not done in this CL yet) and common/, so that chrome/common/DEPS can
whitelist
> common/ only.
> 
> There's a lot more on the wiki:
> 
>
http://dev.chromium.org/developers/design-documents/layered-components-techni...
> 
>
http://dev.chromium.org/developers/design-documents/browser-components/cookbo...
> 
> http://dev.chromium.org/developers/design-documents/layered-components-design
> 
>
http://dev.chromium.org/developers/design-documents/layered-components-techni...

I see. Note that these references suggest you come up with a "design" :) I'll
not force you to write a doc now, but it'd be nice if you could at least dump a
rough plan of what moves where on the bug, in particular considering that you're
on vacation after tomorrow.

[jochen (gone - plz use gerrit), 2013-08-13 13:36:51]

lgtm

[commit-bot: I haz the power, 2013-08-14 07:55:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/23045003/59001

[commit-bot: I haz the power, 2013-08-14 14:41:15]

Change committed as 217552