runtime/observatory/tests/service/pause_on_start_and_exit_test.dart - Issue 2304463002: Converted Observatory vm-view && isolate-view elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/pause_on_start_and_exit_test.dart

Issue 2304463002: Converted Observatory vm-view && isolate-view elements (Closed)

Patch Set: Fixed typo Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/pause_idle_isolate_test.dart ('k') | runtime/observatory/tests/service/pause_on_start_then_step_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/pause_on_start_and_exit_test.dart

diff --git a/runtime/observatory/tests/service/pause_on_start_and_exit_test.dart b/runtime/observatory/tests/service/pause_on_start_and_exit_test.dart

index 93444d0a03b0e1e7ee386763c553185477cd1704..146be22ae44c46716f453a77b87c18e54d35f13f 100644

--- a/runtime/observatory/tests/service/pause_on_start_and_exit_test.dart

+++ b/runtime/observatory/tests/service/pause_on_start_and_exit_test.dart

@@ -3,6 +3,7 @@

// BSD-style license that can be found in the LICENSE file.

// VMOptions=--error_on_bad_type --error_on_bad_override

+import 'package:observatory/models.dart' as M;

import 'package:observatory/service_io.dart';

import 'package:unittest/unittest.dart';

import 'test_helper.dart';

@@ -32,7 +33,7 @@ var tests = [

print('Subscribed. Pause event is ${isolate.pauseEvent}');

if (isolate.pauseEvent != null &&

- isolate.pauseEvent.kind == ServiceEvent.kPauseStart) {

+ isolate.pauseEvent is M.PauseStartEvent) {

// Wait for the isolate to hit PauseStart.

subscription.cancel();

print('Subscription cancelled.');