runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.dart - Issue 2304463002: Converted Observatory vm-view && isolate-view elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.dart

Issue 2304463002: Converted Observatory vm-view && isolate-view elements (Closed)

Patch Set: Fixed typo Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/observatory_sources.gypi ('k') | runtime/observatory/tests/observatory_ui/mocks/objects/isolate.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.dart

diff --git a/runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.dart b/runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.dart

index 14aeeed513f0f67b19a6b84e07ad0775f609dbc3..f87a61a501814383a70fc76725103e882214b36c 100644

--- a/runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.dart

+++ b/runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.dart

@@ -14,12 +14,13 @@ main() {

final cTag = IsolateCounterChartElement.tag.name;

const isolate = const IsolateMock();

+ final events = new EventRepositoryMock();

test('instantiation', () {

- final e = new IsolateSharedSummaryElement(isolate);

+ final e = new IsolateSharedSummaryElement(isolate, events);

expect(e, isNotNull, reason: 'element correctly created');

});

test('elements created', () async {

- final e = new IsolateSharedSummaryElement(isolate);

+ final e = new IsolateSharedSummaryElement(isolate, events);

document.body.append(e);

await e.onRendered.first;

expect(e.children.length, isNonZero, reason: 'has elements');