[oilpan] Fix iterators over member collections to return Result<T>

[oilpan] Fix iterators over member collections to return Result<T>

R=ager@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156209

[Mads Ager (chromium), 2013-08-16 10:23:41]

I agree that iterators should return Results. I would like if we could make more
of this private.

https://codereview.chromium.org/23042005/diff/1/Source/heap/Handle.h
File Source/heap/Handle.h (right):

https://codereview.chromium.org/23042005/diff/1/Source/heap/Handle.h#newcode694
Source/heap/Handle.h:694: template<typename U>
We really shouldn't be using this unless we really know what we are doing. Can
we make this private and only accessible from the iterators?

https://codereview.chromium.org/23042005/diff/1/Source/heap/Visitor.h
File Source/heap/Visitor.h (right):

https://codereview.chromium.org/23042005/diff/1/Source/heap/Visitor.h#newcode122
Source/heap/Visitor.h:122: // Result version of the one-argument templated visit
method.
Could you expand the comment here to state why this is needed. You steal the
pointer from the Result here and we normally do not want to visit any Results at
all.

[Erik Corry, 2013-08-16 11:39:27]

https://codereview.chromium.org/23042005/diff/1/Source/heap/Handle.h
File Source/heap/Handle.h (right):

https://codereview.chromium.org/23042005/diff/1/Source/heap/Handle.h#newcode694
Source/heap/Handle.h:694: template<typename U>
On 2013/08/16 10:23:41, Mads Ager (chromium) wrote:
> We really shouldn't be using this unless we really know what we are doing. Can
> we make this private and only accessible from the iterators?

Done.

https://codereview.chromium.org/23042005/diff/1/Source/heap/Visitor.h
File Source/heap/Visitor.h (right):

https://codereview.chromium.org/23042005/diff/1/Source/heap/Visitor.h#newcode122
Source/heap/Visitor.h:122: // Result version of the one-argument templated visit
method.
On 2013/08/16 10:23:41, Mads Ager (chromium) wrote:
> Could you expand the comment here to state why this is needed. You steal the
> pointer from the Result here and we normally do not want to visit any Results
at
> all.

Done.

[Mads Ager (chromium), 2013-08-16 11:47:40]

LGTM

[Erik Corry, 2013-08-16 12:15:48]

Committed patchset #3 manually as r156209.

[haraken, 2013-08-19 04:28:25]

This CL caused a lot of crashes:
http://haraken-pcz2.tok.corp.google.com/oilpan-bot/bot-results/r156209_0/layo...

[haraken, 2013-08-19 07:42:57]

On 2013/08/19 04:28:25, haraken wrote:
> This CL caused a lot of crashes:
>
http://haraken-pcz2.tok.corp.google.com/oilpan-bot/bot-results/r156209_0/layo...

Oh, this was already fixed in r156224.

Sorry, the build bot was stuck (dead lock?) and are currently running behind the
tip of tree.