Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 23042004: Implement MoveResourceRequest on Drive API v2. (Closed)

Created:
7 years, 4 months ago by hidehiko
Modified:
7 years, 4 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Implement MoveResourceRequest on Drive API v2. This is the implementation of "move" operation on Drive API v2. Then, RenameResourceRequest becomes the limited version of MoveResourceRequest, so it is migrated into it. BUG=241814 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218026

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -114 lines) Patch
M chrome/browser/drive/drive_api_service.cc View 4 chunks +19 lines, -6 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests.h View 2 chunks +37 lines, -30 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests.cc View 2 chunks +58 lines, -45 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests_unittest.cc View 1 2 chunks +75 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 4 months ago (2013-08-16 07:51:13 UTC) #1
kinaba
lgtm+nit https://codereview.chromium.org/23042004/diff/1/chrome/browser/google_apis/drive_api_requests_unittest.cc File chrome/browser/google_apis/drive_api_requests_unittest.cc (right): https://codereview.chromium.org/23042004/diff/1/chrome/browser/google_apis/drive_api_requests_unittest.cc#newcode727 chrome/browser/google_apis/drive_api_requests_unittest.cc:727: // Create "new directory" in the root directory. ...
7 years, 4 months ago (2013-08-16 07:59:52 UTC) #2
hidehiko
Thank you for your quick review. https://codereview.chromium.org/23042004/diff/1/chrome/browser/google_apis/drive_api_requests_unittest.cc File chrome/browser/google_apis/drive_api_requests_unittest.cc (right): https://codereview.chromium.org/23042004/diff/1/chrome/browser/google_apis/drive_api_requests_unittest.cc#newcode727 chrome/browser/google_apis/drive_api_requests_unittest.cc:727: // Create "new ...
7 years, 4 months ago (2013-08-16 08:33:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23042004/6001
7 years, 4 months ago (2013-08-16 14:09:05 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 16:21:35 UTC) #5
Message was sent while issue was closed.
Change committed as 218026

Powered by Google App Engine
This is Rietveld 408576698