Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 23039015: Web MIDI: enable midi_host.cc implementation on Android (Closed)

Created:
7 years, 4 months ago by Takashi Toyoshima
Modified:
7 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Web MIDI: enable midi_host.cc implementation on Android BUG=163795 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218458

Patch Set 1 #

Total comments: 4

Patch Set 2 : review #2 #

Total comments: 4

Patch Set 3 : review #4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M content/browser/renderer_host/media/midi_host.cc View 1 2 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Takashi Toyoshima
Hi scherkus, I find a TODO from crogers to me :) This is easy fix. ...
7 years, 4 months ago (2013-08-19 14:03:51 UTC) #1
scherkus (not reviewing)
https://codereview.chromium.org/23039015/diff/1/content/browser/renderer_host/media/midi_host.cc File content/browser/renderer_host/media/midi_host.cc (left): https://codereview.chromium.org/23039015/diff/1/content/browser/renderer_host/media/midi_host.cc#oldcode114 content/browser/renderer_host/media/midi_host.cc:114: // TODO(toyoshim): figure out why data() method does not ...
7 years, 4 months ago (2013-08-19 17:28:20 UTC) #2
Takashi Toyoshima
Thanks! I uploaded Patch Set 2. https://codereview.chromium.org/23039015/diff/1/content/browser/renderer_host/media/midi_host.cc File content/browser/renderer_host/media/midi_host.cc (left): https://codereview.chromium.org/23039015/diff/1/content/browser/renderer_host/media/midi_host.cc#oldcode114 content/browser/renderer_host/media/midi_host.cc:114: // TODO(toyoshim): figure ...
7 years, 4 months ago (2013-08-19 18:03:40 UTC) #3
scherkus (not reviewing)
lgtm https://codereview.chromium.org/23039015/diff/10001/content/browser/renderer_host/media/midi_host.cc File content/browser/renderer_host/media/midi_host.cc (right): https://codereview.chromium.org/23039015/diff/10001/content/browser/renderer_host/media/midi_host.cc#newcode97 content/browser/renderer_host/media/midi_host.cc:97: if (data.size() == 0) nit: data.empty() ? https://codereview.chromium.org/23039015/diff/10001/content/browser/renderer_host/media/midi_host.cc#newcode119 ...
7 years, 4 months ago (2013-08-19 18:08:03 UTC) #4
Takashi Toyoshima
Thank you for taking a look! I uploaded the fixed version as Patch Set 3. ...
7 years, 4 months ago (2013-08-19 18:41:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/23039015/15001
7 years, 4 months ago (2013-08-19 18:43:50 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 12:09:07 UTC) #7
Message was sent while issue was closed.
Change committed as 218458

Powered by Google App Engine
This is Rietveld 408576698