Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: Source/core/animation/TimedItem.h

Issue 23039013: Web Animations: Fix elpasedTime in animation events (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed elapsedTime for negative delay and added a test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/animations/negative-delay-events-expected.txt ('k') | Source/core/animation/TimedItem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/TimedItem.h
diff --git a/Source/core/animation/TimedItem.h b/Source/core/animation/TimedItem.h
index 501a71170224154f1a2230bacd501a110f04793e..6cb108be2844e472f010e31091fca90122eeb56f 100644
--- a/Source/core/animation/TimedItem.h
+++ b/Source/core/animation/TimedItem.h
@@ -38,6 +38,7 @@
namespace WebCore {
class Player;
+class TimedItem;
static inline bool isNull(double value)
{
@@ -63,7 +64,7 @@ public:
class EventDelegate {
public:
virtual ~EventDelegate() { };
- virtual void onEventCondition(bool isFirstSample, Phase previousPhase, Phase currentPhase, double previousIteration, double currentIteration) = 0;
+ virtual void onEventCondition(const TimedItem*, bool isFirstSample, Phase previousPhase, double previousIteration) = 0;
};
virtual ~TimedItem() { }
@@ -78,7 +79,9 @@ public:
double currentIteration() const { return ensureCalculated().currentIteration; }
double activeDuration() const { return ensureCalculated().activeDuration; }
double timeFraction() const { return ensureCalculated().timeFraction; }
- Player* player() const { return m_player; }
+ const Player* player() const { return m_player; }
+
+ const Timing& specified() const { return m_specified; }
protected:
TimedItem(const Timing&, PassOwnPtr<EventDelegate> = nullptr);
« no previous file with comments | « LayoutTests/animations/negative-delay-events-expected.txt ('k') | Source/core/animation/TimedItem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698