Issue 23039009: Settings: Profile name text field should have focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23039009: Settings: Profile name text field should have focus. (Closed)

Created:
7 years, 4 months ago by tkent

Modified:
7 years, 4 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Settings: Profile name text field should have focus. ManageProfileOverlay gives focus to the profile name text field in didShowPage() function. However OptionsPage.showOvelay_ called document.activeElement.blur() after the didShowPage() call. We should avoid to call blur() if the overlay already has focus. BUG=271297 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217758

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/options/options_page.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/23039009/1

7 years, 4 months ago (2013-08-14 23:10:43 UTC) #3

Message was sent while issue was closed.

Change committed as 217758

Expand Messages | Collapse Messages