Issue 23037008: [MIPS] Default the Android build to mips32r1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23037008: [MIPS] Default the Android build to mips32r1. (Closed)

Created:
7 years, 4 months ago by paul.l...

Modified:
6 years, 10 months ago

Reviewers:
cjhopman, Yaron, Nico, Torne, Paul Lind

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, petarj

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[MIPS] Default the Android build to mips32r1. Intent is to allow a single Android build (apk) to support all MIPS compatible devices, such as Broadcom, by using a common architecture variant. Linux builds are typically customized per-device, and will still default to mips32r2. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218942

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/android/envsetup_functions.sh	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm I can't really test or verify this but there's no supported build of mips ...

7 years, 4 months ago (2013-08-21 23:46:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/paul.lind@imgtec.com/23037008/1

7 years, 4 months ago (2013-08-22 00:37:15 UTC) #3

Nico

6 years, 10 months ago (2014-02-02 03:16:34 UTC) #5

Message was sent while issue was closed.

This looks wrong to me. https://codereview.chromium.org/152233002/ changes the
default value in build/common.gypi instead, which looks like a better patch to
me – if you disagree, please shout on that review.

Expand Messages | Collapse Messages