Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 23033006: Change DumpRenderTree_resources to use ui_resources_100_percent.pak. (Closed)

Created:
7 years, 4 months ago by tfarina
Modified:
7 years, 4 months ago
Reviewers:
oshima, abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Change DumpRenderTree_resources to use ui_resources_100_percent.pak. This should help address the TODO ui/resources/ui_resources.grd and ui/ui_resources.gypi on Chromium. Once this lands and rolls on Chromium, then we can update on the Chromium side. R=abarth@chromium.org,oshima@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/testing/testing.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
7 years, 4 months ago (2013-08-16 02:39:18 UTC) #1
oshima
lgtm thank you for cleaning this up!
7 years, 4 months ago (2013-08-16 03:24:19 UTC) #2
abarth-chromium
lgtm
7 years, 4 months ago (2013-08-16 04:31:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23033006/1
7 years, 4 months ago (2013-08-17 01:07:18 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-17 02:45:00 UTC) #5
Message was sent while issue was closed.
Change committed as 156259

Powered by Google App Engine
This is Rietveld 408576698