Chromium Code Reviews Chromium Code Reviews
Issue
23030005:
Android: exclude dead code from android build (Closed)
DescriptionAndroid: exclude dead code from android build
Dead code is found examining symbols in the final targets of the 'All' build target.
Note, Ninja/Gyp combination does not provide a mechanism to
blocking include files. A later change could make something undead and the developer would get a link error, where they might expect a compile error.
I didn't modify GYP files were there was currently no branching or where there was already a very complex set of conditional configurations. Other than these cases which are minor, the majority of remaining dead code is because we link third party libraries with whole-archive flag.
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220856
Patch Set 1 #Patch Set 2 : Slightly less aggressive for clang. #Patch Set 3 : Removed unnecessary ordering changes #Patch Set 4 : cosmetic whitespace #Patch Set 5 : Don't exclude vector_canvas #
Total comments: 2
Patch Set 6 : Fix ordering in ui.gyp #
Total comments: 2
Patch Set 7 : Remove find_match_rect_android and font_list_android #Patch Set 8 : Fixes for build breakage #
Messages
Total messages: 17 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
