impl/prod/raw_datastore_type_converter.go - Issue 2302743002: Interface update, per-method Contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/prod/raw_datastore_type_converter.go

Issue 2302743002: Interface update, per-method Contexts. (Closed)

Patch Set: WithoutTransaction, comments, fixes, cleanup. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/prod/raw_datastore_type_converter.go

diff --git a/impl/prod/raw_datastore_type_converter.go b/impl/prod/raw_datastore_type_converter.go

index 9799d577233b0c6f3ccc69498fd61ca41ad180f2..1fc439a3f83b90f1c9f91a474bec623e46fb42f2 100644

--- a/impl/prod/raw_datastore_type_converter.go

+++ b/impl/prod/raw_datastore_type_converter.go

@@ -82,7 +82,7 @@ func maybeIndexValue(val interface{}) interface{} {

toks[i].StringID = sid.Elem().String()

}

- return ds.NewKeyToks(aid, ns, toks)

+ return ds.KeyContext{aid, ns}.NewKeyToks(toks)

}

panic(fmt.Errorf(

"UNKNOWN datastore.indexValue field type: %s", field.Type()))