Interface update, per-method Contexts.

filter/featureBreaker/gi.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package featureBreaker
 
 import (
         "time"
 
         "golang.org/x/net/context"
@@ skipping 16 matching lines @@
 }
 
 func (g *infoState) ServiceAccount() (ret string, err error) {
         err = g.run(func() (err error) {
                 ret, err = g.RawInterface.ServiceAccount()
                 return
         })
         return
 }
 
-func (g *infoState) Namespace(namespace string) (ret context.Context, err error) {
-        err = g.run(func() (err error) {
-                ret, err = g.RawInterface.Namespace(namespace)
-                return
+func (g *infoState) Namespace(namespace string) (c context.Context, err error) {
+        err = g.run(func() error {
+                c, err = g.RawInterface.Namespace(namespace)

[iannucci, 2016/09/16 01:01:13]

I think this is wrong now; this err was intentionally aliased before so that the
inner err was scoped to the inner function. Now it leaks and then gets
overwritten later.

[dnj, 2016/09/16 05:44:42]

Done.

+                return err
         })
         return
 }
 
 func (g *infoState) AccessToken(scopes ...string) (token string, expiry time.Time, err error) {
         err = g.run(func() (err error) {
                 token, expiry, err = g.RawInterface.AccessToken(scopes...)
                 return
         })
         return
@@ skipping 15 matching lines @@
         return
 }
 
 // FilterGI installs a featureBreaker info filter in the context.
 func FilterGI(c context.Context, defaultError error) (context.Context, FeatureBreaker) {
         state := newState(defaultError)
         return info.AddFilters(c, func(ic context.Context, i info.RawInterface) info.RawInterface {
                 return &infoState{state, i}
         }), state
 }