src/core/SkImageFilter.cpp - Issue 23021015: Initial error handling code - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(133)

My Issues | Starred Open | Closed | All

Unified Diff: src/core/SkImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Adapting code to sk_once changes Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « src/core/SkGraphics.cpp ('k') | src/core/SkOrderedReadBuffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/core/SkImageFilter.cpp

diff --git a/src/core/SkImageFilter.cpp b/src/core/SkImageFilter.cpp

index 6ec982bbfb5a01b873479f2c32c4d1aeffe94d97..9bf392515dbf0cc3e63942e9511e3035f568cfbc 100644

--- a/src/core/SkImageFilter.cpp

+++ b/src/core/SkImageFilter.cpp

@@ -10,6 +10,7 @@

#include "SkBitmap.h"

#include "SkFlattenableBuffers.h"

#include "SkRect.h"

+#include "SkValidationUtils.h"

#if SK_SUPPORT_GPU

#include "GrContext.h"

#include "GrTexture.h"

@@ -65,6 +66,7 @@ SkImageFilter::SkImageFilter(SkFlattenableReadBuffer& buffer)

buffer.readRect(&rect);

uint32_t flags = buffer.readUInt();

fCropRect = CropRect(rect, flags);

+ buffer.validate(SkIsValidRect(rect));

}

void SkImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {

« no previous file with comments | « src/core/SkGraphics.cpp ('k') | src/core/SkOrderedReadBuffer.h » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698