Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 23020034: Don't build debugger on 32-bit Linux (Closed)

Created:
7 years, 3 months ago by borenet
Modified:
7 years, 3 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Don't build debugger on 32-bit Linux R=rmistry@google.com Committed: https://code.google.com/p/skia/source/detail?r=10914

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Messages

Total messages: 5 (0 generated)
borenet
7 years, 3 months ago (2013-08-26 13:13:20 UTC) #1
rmistry
LGTM https://codereview.chromium.org/23020034/diff/1/master/skia_master_scripts/factory.py File master/skia_master_scripts/factory.py (right): https://codereview.chromium.org/23020034/diff/1/master/skia_master_scripts/factory.py#newcode694 master/skia_master_scripts/factory.py:694: # Don't compile the debugger in 64-bit Win7 ...
7 years, 3 months ago (2013-08-26 13:23:15 UTC) #2
borenet
Patch set 2. https://codereview.chromium.org/23020034/diff/1/master/skia_master_scripts/factory.py File master/skia_master_scripts/factory.py (right): https://codereview.chromium.org/23020034/diff/1/master/skia_master_scripts/factory.py#newcode694 master/skia_master_scripts/factory.py:694: # Don't compile the debugger in ...
7 years, 3 months ago (2013-08-26 13:28:32 UTC) #3
rmistry
LGTM
7 years, 3 months ago (2013-08-26 13:28:56 UTC) #4
borenet
7 years, 3 months ago (2013-08-26 13:33:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r10914 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698