Issue 23019005: Clear the QUIC cached proof when a client receives a REJ w/o a PROF tag.

Issue 23019005: Clear the QUIC cached proof when a client receives a REJ w/o a PROF tag. (Closed)

Created:
7 years, 4 months ago by Ryan Hamilton

Modified:
7 years, 4 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clear the QUIC cached proof when a client receives a REJ w/o a PROF tag. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217760

Patch Set 2 : Fix comments #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	net/quic/crypto/crypto_handshake.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	net/quic/crypto/crypto_handshake.cc	View	1	3 chunks	+20 lines, -2 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

wtc

Patch set 1 LGTM. https://codereview.chromium.org/23019005/diff/1/net/quic/crypto/crypto_handshake.h File net/quic/crypto/crypto_handshake.h (right): https://codereview.chromium.org/23019005/diff/1/net/quic/crypto/crypto_handshake.h#newcode269 net/quic/crypto/crypto_handshake.h:269: void ClearProof(); Please add a ...

7 years, 4 months ago (2013-08-14 23:48:42 UTC) #2

Ryan Hamilton

Thanks! https://codereview.chromium.org/23019005/diff/1/net/quic/crypto/crypto_handshake.h File net/quic/crypto/crypto_handshake.h (right): https://codereview.chromium.org/23019005/diff/1/net/quic/crypto/crypto_handshake.h#newcode269 net/quic/crypto/crypto_handshake.h:269: void ClearProof(); On 2013/08/14 23:48:42, wtc wrote: > ...

7 years, 4 months ago (2013-08-15 03:27:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/23019005/6001

7 years, 4 months ago (2013-08-15 03:35:38 UTC) #4

wtc

7 years, 4 months ago (2013-08-15 16:33:05 UTC) #6

Message was sent while issue was closed.

Patch set 2 LGTM.

https://chromiumcodereview.appspot.com/23019005/diff/6001/net/quic/crypto/cry...
File net/quic/crypto/crypto_handshake.cc (right):

https://chromiumcodereview.appspot.com/23019005/diff/6001/net/quic/crypto/cry...
net/quic/crypto/crypto_handshake.cc:837: *error_details = "Certificate data
invalid";

It seems that we should also call cached->ClearProof() in
this case ...

Expand Messages | Collapse Messages