sdk/lib/_internal/lib/js_rti.dart - Issue 23012003: Add Null class to dart:core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_rti.dart

Issue 23012003: Add Null class to dart:core. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Marked test failing due to new dart2js mirror bug. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/lib/js_rti.dart

diff --git a/sdk/lib/_internal/lib/js_rti.dart b/sdk/lib/_internal/lib/js_rti.dart

index 4441214b8e9de4386f3a08042c4de780eca502f0..a397d6b5bd5afde3ac78f28ef8279efa0a8f8f23 100644

--- a/sdk/lib/_internal/lib/js_rti.dart

+++ b/sdk/lib/_internal/lib/js_rti.dart

@@ -383,7 +383,8 @@ computeSignature(var signature, var context, var contextName) {

bool isSupertypeOfNull(var type) {

// `null` means `dynamic`.

- return isNull(type) || getConstructorName(type) == JS_OBJECT_CLASS_NAME();

+ return isNull(type) || getConstructorName(type) == JS_OBJECT_CLASS_NAME()

+ || getConstructorName(type) == JS_NULL_CLASS_NAME();

ahe 2013/08/15 11:16:46 I have a strong suspicion that it would make sense

Lasse Reichstein Nielsen 2013/08/15 13:06:10 Done.

}

/**