sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 23012003: Add Null class to dart:core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 23012003: Add Null class to dart:core. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Marked test failing due to new dart2js mirror bug. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

index 2b0107718edb420e00e079a85d8aab397837d2d9..9460e6b05a8b3c10bef69fdb36d36b6ba823a8cd 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

@@ -583,7 +583,8 @@ class SsaConstantFolder extends HBaseVisitor implements OptimizationPhase {

// raw type.

} else if (!RuntimeTypes.hasTypeArguments(type)) {

TypeMask expressionMask = expressionType.computeMask(compiler);

- TypeMask typeMask = new TypeMask.nonNullSubtype(type);

+ TypeMask typeMask = (element == compiler.nullClass)

+ ? new TypeMask.subtype(type) : new TypeMask.nonNullSubtype(type);

if (expressionMask.union(typeMask, compiler) == typeMask) {

return graph.addConstantBool(true, compiler);

} else if (expressionMask.intersection(typeMask, compiler).isEmpty) {