Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 23011018: Modify Pepper CreateResourceHostFromHost to create multiple hosts. (Closed)

Created:
7 years, 4 months ago by raymes
Modified:
7 years, 4 months ago
Reviewers:
Tom Sepez, teravest, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Modify Pepper CreateResourceHostFromHost to create multiple hosts. This alters CreateResourceHostFromHost so that multiple resource hosts can be created with a single IPC. The general case is for many resources to be created at the same time. For example, you may pass an array of file refs across IPC. BUG=177017 TBR=teravest@chromium.org, tsepez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218884

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -79 lines) Patch
M content/browser/renderer_host/pepper/pepper_renderer_connection.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_renderer_connection.cc View 1 2 2 chunks +29 lines, -26 lines 0 comments Download
M content/public/renderer/renderer_ppapi_host.h View 1 2 chunks +10 lines, -8 lines 0 comments Download
M content/renderer/pepper/mock_renderer_ppapi_host.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/pepper/mock_renderer_ppapi_host.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_browser_connection.h View 1 4 chunks +9 lines, -6 lines 0 comments Download
M content/renderer/pepper/pepper_browser_connection.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.h View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
raymes
7 years, 4 months ago (2013-08-15 07:25:08 UTC) #1
teravest
lgtm Seems pretty straightforward to me.
7 years, 4 months ago (2013-08-15 14:11:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/23011018/13001
7 years, 4 months ago (2013-08-16 00:55:32 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=20912
7 years, 4 months ago (2013-08-16 01:11:42 UTC) #4
raymes
TBR=jam for simple changes to the content API
7 years, 4 months ago (2013-08-16 01:38:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/23011018/13001
7 years, 4 months ago (2013-08-16 01:40:34 UTC) #6
commit-bot: I haz the power
Change committed as 217948
7 years, 4 months ago (2013-08-16 05:43:24 UTC) #7
Tom Sepez
Messages LGTM. https://chromiumcodereview.appspot.com/23011018/diff/13001/ppapi/proxy/ppapi_messages.h File ppapi/proxy/ppapi_messages.h (right): https://chromiumcodereview.appspot.com/23011018/diff/13001/ppapi/proxy/ppapi_messages.h#newcode1292 ppapi/proxy/ppapi_messages.h:1292: // in the request and the IDs ...
7 years, 4 months ago (2013-08-19 17:18:15 UTC) #8
raymes
teravest: PTAL at the delta with the previous patchset. I found the bug causing the ...
7 years, 4 months ago (2013-08-21 01:48:27 UTC) #9
teravest
lgtm Good catch.
7 years, 4 months ago (2013-08-21 03:00:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/23011018/60001
7 years, 4 months ago (2013-08-21 03:03:47 UTC) #11
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 4 months ago (2013-08-21 09:26:36 UTC) #12
raymes
Committed patchset #4 manually as r218884 (presubmit successful).
7 years, 4 months ago (2013-08-22 00:43:51 UTC) #13
jam
lgtm
7 years, 4 months ago (2013-08-25 13:03:02 UTC) #14
jam
7 years, 4 months ago (2013-08-25 13:03:03 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698