Implement computed style for animation shorthand and align parsing with the spec.

Implement computed style for animation shorthand and align parsing with the spec.

Implement the computed style for the animation shorthand which will avoid
to return "".

Improve parsing of the shorthand by adding the play-state property part of the parsing. This align with the spec and it was changed at the end of last
year.

Remove dead code in CSSParser-in.cpp inherited from the transitions.

There are few commented tests that are not passing as they do not yet
align with the spec. It's a trickier issue that I will fix in a following patch (bug is linked).

BUG=272963, 234612
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156170

[esprehn, 2013-08-15 18:29:29]

https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
File Source/core/css/CSSComputedStyleDeclaration.cpp (right):

https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
Source/core/css/CSSComputedStyleDeclaration.cpp:1192: static
PassRefPtr<CSSValue> getAnimationFillModeValue(unsigned fillMode)
These methods are named wrong. Don't prefix with get*

https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
Source/core/css/CSSComputedStyleDeclaration.cpp:1205: return
cssValuePool().createIdentifierValue(CSSValueNone);
return null, you can't reach it anyway.

https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
Source/core/css/CSSComputedStyleDeclaration.cpp:1222: return
cssValuePool().createIdentifierValue(CSSValueNormal);
ditto.

https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
Source/core/css/CSSComputedStyleDeclaration.cpp:2467: const
CSSAnimationDataList* animList = style->animations();
don't abbreviate, -> animations

[darktears, 2013-08-15 18:36:17]

On 2013/08/15 18:29:29, esprehn wrote:
>
https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
> File Source/core/css/CSSComputedStyleDeclaration.cpp (right):
> 
>
https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
> Source/core/css/CSSComputedStyleDeclaration.cpp:1192: static
> PassRefPtr<CSSValue> getAnimationFillModeValue(unsigned fillMode)
> These methods are named wrong. Don't prefix with get*

Just following the pattern of the entire file but ok.

> 
>
https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
> Source/core/css/CSSComputedStyleDeclaration.cpp:1205: return
> cssValuePool().createIdentifierValue(CSSValueNone);
> return null, you can't reach it anyway.

ok.

> 
>
https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
> Source/core/css/CSSComputedStyleDeclaration.cpp:1222: return
> cssValuePool().createIdentifierValue(CSSValueNormal);
> ditto.
> 
>
https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
> Source/core/css/CSSComputedStyleDeclaration.cpp:2467: const
> CSSAnimationDataList* animList = style->animations();
> don't abbreviate, -> animations

Sure.

[darktears, 2013-08-15 18:44:03]

On 2013/08/15 18:36:17, darktears wrote:
> On 2013/08/15 18:29:29, esprehn wrote:
> >
>
https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
> > File Source/core/css/CSSComputedStyleDeclaration.cpp (right):
> > 
> >
>
https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
> > Source/core/css/CSSComputedStyleDeclaration.cpp:1192: static
> > PassRefPtr<CSSValue> getAnimationFillModeValue(unsigned fillMode)
> > These methods are named wrong. Don't prefix with get*
> 
> Just following the pattern of the entire file but ok.

Seems like there is a mixture with valueFor*** so I will pick the later and make
a refactoring patch for the names later (to keep things consistent).

> 
> > 
> >
>
https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
> > Source/core/css/CSSComputedStyleDeclaration.cpp:1205: return
> > cssValuePool().createIdentifierValue(CSSValueNone);
> > return null, you can't reach it anyway.
> 
> ok.
> 
> > 
> >
>
https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
> > Source/core/css/CSSComputedStyleDeclaration.cpp:1222: return
> > cssValuePool().createIdentifierValue(CSSValueNormal);
> > ditto.
> > 
> >
>
https://codereview.chromium.org/23011009/diff/1/Source/core/css/CSSComputedSt...
> > Source/core/css/CSSComputedStyleDeclaration.cpp:2467: const
> > CSSAnimationDataList* animList = style->animations();
> > don't abbreviate, -> animations
> 
> Sure.

[esprehn, 2013-08-15 19:21:51]

LGTM

[darktears, 2013-08-15 20:10:21]

On 2013/08/15 19:21:51, esprehn wrote:
> LGTM

TabAtkins : Never mind, then.  LGTM

[commit-bot: I haz the power, 2013-08-15 20:10:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexis.menard@intel.com/23011009/15001

[commit-bot: I haz the power, 2013-08-15 21:54:47]

Change committed as 156170