Whitelist TimeScapes to access restricted native local filesystem.

Whitelist TimeScapes to access restricted native local filesystem.

Recently, access to oem data has been disabled by default, and it is enabled only for Files.app. However, TimeScapes is an external extension and lost ability to play the movie which is in the oem directory. This patch temporarily whitelists TimeScapes to let it access the video.
Note, that this is just a temporary solution, and we should either restore access to read only native file systems to everyone, or grant it to TimeScapes in a proper way.

TEST=TimeScapes should play correctly in M-30.
BUG=262265
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217247

[mtomasz, 2013-08-13 04:21:41]

@kinuko: Please verify.
@satorux: PTAL as an OWNER.

[mtomasz, 2013-08-13 04:22:11]

On 2013/08/13 04:21:41, mtomasz wrote:
> @kinuko: Please verify.
> @satorux: PTAL as an OWNER.

s/verify/check/

[mtomasz, 2013-08-13 04:22:42]

On 2013/08/13 04:22:11, mtomasz wrote:
> On 2013/08/13 04:21:41, mtomasz wrote:
> > @kinuko: Please verify.
> > @satorux: PTAL as an OWNER.
> 
> s/verify/check/

s/check/take a look/

[kinuko, 2013-08-13 04:32:01]

lgtm as a fix for M-30

(cc-ing toni who probably knows better about oem access control)

[satorux1, 2013-08-13 04:39:21]

https://codereview.chromium.org/23011002/diff/1/chrome/browser/chromeos/filea...
File chrome/browser/chromeos/fileapi/file_system_backend.cc (right):

https://codereview.chromium.org/23011002/diff/1/chrome/browser/chromeos/filea...
chrome/browser/chromeos/fileapi/file_system_backend.cc:145: // TODO(mtomasz):
Temporarily whitelist TimeScapes. Remove this in M-31.
Please file a bug and add a URL for it.

[mtomasz, 2013-08-13 05:35:25]

https://codereview.chromium.org/23011002/diff/1/chrome/browser/chromeos/filea...
File chrome/browser/chromeos/fileapi/file_system_backend.cc (right):

https://codereview.chromium.org/23011002/diff/1/chrome/browser/chromeos/filea...
chrome/browser/chromeos/fileapi/file_system_backend.cc:145: // TODO(mtomasz):
Temporarily whitelist TimeScapes. Remove this in M-31.
On 2013/08/13 04:39:21, satorux1 wrote:
> Please file a bug and add a URL for it.

Done.

[satorux1, 2013-08-13 05:41:25]

LGTM

[commit-bot: I haz the power, 2013-08-13 05:44:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/23011002/2

[commit-bot: I haz the power, 2013-08-13 12:15:15]

Change committed as 217247

[tbarzic, 2013-08-14 23:18:10]

https://chromiumcodereview.appspot.com/23011002/diff/2/chrome/browser/chromeo...
File chrome/browser/chromeos/fileapi/file_system_backend.cc (right):

https://chromiumcodereview.appspot.com/23011002/diff/2/chrome/browser/chromeo...
chrome/browser/chromeos/fileapi/file_system_backend.cc:148: url.mount_type() ==
fileapi::kFileSystemTypeRestrictedNativeLocal) {
does this actually work?
I think that url.mount_type is never set to kFileSystemTypeRestrictedNativeLocal
(it should be kFileSystemTypeExternal in this case)

url.type() should be used instead..

[mtomasz, 2013-08-15 02:02:21]

https://chromiumcodereview.appspot.com/23011002/diff/2/chrome/browser/chromeo...
File chrome/browser/chromeos/fileapi/file_system_backend.cc (right):

https://chromiumcodereview.appspot.com/23011002/diff/2/chrome/browser/chromeo...
chrome/browser/chromeos/fileapi/file_system_backend.cc:148: url.mount_type() ==
fileapi::kFileSystemTypeRestrictedNativeLocal) {
Oops! Good catch!