chrome/browser/extensions/extension_host.h - Issue 23007021: Report Javascript Runtime Errors to the Error Console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_host.h

Issue 23007021: Report Javascript Runtime Errors to the Error Console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_feldman

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/error_console/error_console_unittest.cc ('k') | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_host.h

diff --git a/chrome/browser/extensions/extension_host.h b/chrome/browser/extensions/extension_host.h

index fe97ef2ad5460dc7bef423996d0f3b4b575c9aff..43f44f00eb41f2176c609db4b4d2f87a69ca1f40 100644

--- a/chrome/browser/extensions/extension_host.h

+++ b/chrome/browser/extensions/extension_host.h

@@ -17,6 +17,7 @@

#include "content/public/browser/notification_registrar.h"

#include "content/public/browser/web_contents_delegate.h"

#include "content/public/browser/web_contents_observer.h"

+#include "extensions/common/stack_frame.h"

#include "extensions/common/view_type.h"

#if defined(TOOLKIT_VIEWS)

@@ -221,6 +222,11 @@ class ExtensionHost : public content::WebContentsDelegate,

void OnEventAck();

void OnIncrementLazyKeepaliveCount();

void OnDecrementLazyKeepaliveCount();

+ void OnDetailedConsoleMessageAdded(

+ const base::string16& message,

+ const base::string16& source,

+ const StackTrace& stack_trace,

+ int32 severity_level);

// Handles keyboard events that were not handled by HandleKeyboardEvent().

// Platform specific implementation may override this method to handle the

« no previous file with comments | « chrome/browser/extensions/error_console/error_console_unittest.cc ('k') | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »