Report Javascript Runtime Errors to the Error Console

chrome/browser/extensions/error_console/error_console_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/error_console/error_console.h"
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/extensions/feature_switch.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/common/url_constants.h"
 #include "extensions/browser/extension_error.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/id_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
 
 using base::string16;
-using base::UTF8ToUTF16;
 
 namespace extensions {
 
 namespace {
 
-const char kExecutionContextURLKey[] = "executionContextURL";
-const char kStackTraceKey[] = "stackTrace";
+const char kDefaultStackTrace[] = "function_name (https://url.com:1:1)";
 
-string16 CreateErrorDetails(const std::string& extension_id) {
-  base::DictionaryValue value;
-  value.SetString(
-      kExecutionContextURLKey,
+StackTrace GetDefaultStackTrace() {
+  StackTrace stack_trace;
+  scoped_ptr<StackFrame> frame =
+      StackFrame::CreateFromText(base::UTF8ToUTF16(kDefaultStackTrace));
+  CHECK(frame.get());
+  stack_trace.push_back(*frame);
+  return stack_trace;
+}
+
+string16 GetSourceForExtensionId(const std::string& extension_id) {
+  return base::UTF8ToUTF16(
       std::string(kExtensionScheme) +
-          content::kStandardSchemeSeparator +
-          extension_id);
-  value.Set(kStackTraceKey, new ListValue);
-  std::string json_utf8;
-  base::JSONWriter::Write(&value, &json_utf8);
-  return UTF8ToUTF16(json_utf8);
+      content::kStandardSchemeSeparator +
+      extension_id);
 }
 
 scoped_ptr<ExtensionError> CreateNewRuntimeError(
     bool from_incognito,
     const std::string& extension_id,
     const string16& message) {
   return scoped_ptr<ExtensionError>(new RuntimeError(
       from_incognito,
-      UTF8ToUTF16("source"),
+      GetSourceForExtensionId(extension_id),
       message,
-      logging::LOG_INFO,
-      CreateErrorDetails(extension_id)));
+      GetDefaultStackTrace(),
+      GURL::EmptyGURL(),  // no context url
+      logging::LOG_INFO));
 }
 
 }  // namespace
 
 class ErrorConsoleUnitTest : public testing::Test {
  public:
   ErrorConsoleUnitTest() : error_console_(NULL) { }
   virtual ~ErrorConsoleUnitTest() { }
 
   virtual void SetUp() OVERRIDE {
@@ skipping 127 matching lines @@
       error_console_->GetErrorsForExtension(kId);
   ASSERT_EQ(kNumErrors, errors.size());
 
   // The duplicate error should be the last reported (pointer comparison)...
   ASSERT_EQ(weak_error, errors.back());
   // ... and should have two reported occurrences.
   ASSERT_EQ(2u, errors.back()->occurrences());
 }
 
 }  // namespace extensions