Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 23007002: Add Joe Knoll (joe.knoll@workday.com> to the AUTHORS file. (Closed)

Created:
7 years, 4 months ago by robertshield
Modified:
7 years, 4 months ago
Reviewers:
JoeK, grt (UTC plus 2)
CC:
chromium-reviews
Visibility:
Public.

Description

Add Joe Knoll (joe.knoll@workday.com>; to the AUTHORS file. BUG=NONE TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertshield
This will add Joe to the AUTHORS file. He has already signed the contributor's agreement. ...
7 years, 4 months ago (2013-08-13 12:24:37 UTC) #1
grt (UTC plus 2)
lgtm
7 years, 4 months ago (2013-08-14 04:37:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/23007002/1
7 years, 4 months ago (2013-08-14 04:39:31 UTC) #3
commit-bot: I haz the power
Change committed as 217513
7 years, 4 months ago (2013-08-14 09:54:34 UTC) #4
JoeK
7 years, 4 months ago (2013-08-14 22:59:49 UTC) #5
I think we should go with joe.knoll@workday.com as I'm doing the changes under
Workday's umbrella.

-----Original Message-----
From: robertshield@chromium.org [mailto:robertshield@chromium.org] 
Sent: Tuesday, August 13, 2013 5:25 AM
To: grt@chromium.org; Joe Knoll
Cc: chromium-reviews@chromium.org
Subject: Add Joe Knoll (joe.knoll@workday.com> to the AUTHORS file. (issue
23007002)

Reviewers: grt, joe.knoll_workday.com,

Message:
This will add Joe to the AUTHORS file. He has already signed the contributor's
agreement. Note however that this includes his joe.knoll@workday.com email
address, rather than the gmail address I saw used in his patch.

Joe, which email address do you wish your patches to be attributed to?

Description:
Add Joe Knoll (joe.knoll@workday.com> to the AUTHORS file.

BUG=NONE
TEST=NONE

Please review this at https://codereview.chromium.org/23007002/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
   AUTHORS


Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
f770e739e464b0b1674e19add12055d257794c12..496963a35b9853b20335d35f251f52a02b91c105
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -107,6 +107,7 @@ Jesus Sanchez-Palencia
<jesus.sanchez-palencia.fernandez.fil@intel.com>
  Jin Yang <jin.a.yang@intel.com>
  Jingwei Liu <kingweiliu@gmail.com>
  Jinwoo Song <jinwoo7.song@samsung.com>
+Joe Knoll <joe.knoll@workday.com>
  Joe Thomas <mhx348@motorola.com>
  Joel Stanley <joel@jms.id.au>
  Johannes Rudolph <johannes.rudolph@googlemail.com>


Powered by Google App Engine
This is Rietveld 408576698