LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html - Issue 23005006: Fix XMLHttpRequest leak document when send() is called multiple times.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/TreeWalker/TreeWalker-leak-document.html

Issue 23005006: Fix XMLHttpRequest leak document when send() is called multiple times. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: check readyState == 4 to comply with change made in r156212 Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <body>	2 <body>

3 <script id='targetJS' type='text/html'>	3 <script id='targetJS' type='text/html'>

4 // This test asserts that document doesn't leak when a NodeFilter callba ck referencing the document is created.	4 // This test asserts that document doesn't leak when a NodeFilter callba ck referencing the document is created.

5 keepTreeWalker = document.createTreeWalker(document, NodeFilter.SHOW_ELE MENT, function(node) { return NodeFilter.SHOW_ELEMENT; }, false);	5 keepTreeWalker = document.createTreeWalker(document, NodeFilter.SHOW_ELE MENT, function(node) { return NodeFilter.SHOW_ELEMENT; }, false);

6 </script>	6 </script>

7	7

8 <script src="../../js/resources/js-test-pre.js"></script>	8 <script src="../../js/resources/js-test-pre.js"></script>

9 <script src="../../dom/resources/leak-check.js"></script>	9 <script src="../../js/resources/leak-check.js"></script>

10 <script>	10 <script>

11 var target = '<script>'+grabScriptText('targetJS')+'<'+'/script>';	11 var target = '<script>'+grabScriptText('targetJS')+'<'+'/script>';

12 var tolerance = {'numberOfLiveDocuments': 0};	12 var tolerance = {'numberOfLiveDocuments': 0};

13	13

14 doLeakTest(htmlToUrl(target), tolerance);	14 doLeakTest(htmlToUrl(target), tolerance);

15 </script>	15 </script>

16 <script src="../../js/resources/js-test-post.js"></script>	16 <script src="../../js/resources/js-test-post.js"></script>

17 </body>	17 </body>

18 </html>	18 </html>

OLD	NEW