tests/PDFPrimitivesTest.cpp - Issue 23003035: Fix leaked SkPDFDevice in PDFPrimitivesTest.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PDFPrimitivesTest.cpp

Issue 23003035: Fix leaked SkPDFDevice in PDFPrimitivesTest.cpp (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PDFPrimitivesTest.cpp

===================================================================

--- tests/PDFPrimitivesTest.cpp (revision 10896)

+++ tests/PDFPrimitivesTest.cpp (working copy)

@@ -250,7 +250,7 @@

static void TestImage(skiatest::Reporter* reporter, const SkBitmap& bitmap,

const char* expected, bool useDCTEncoder) {

SkISize pageSize = SkISize::Make(bitmap.width(), bitmap.height());

- SkPDFDevice* dev = new SkPDFDevice(pageSize, pageSize, SkMatrix::I());

+ SkAutoTUnref<SkPDFDevice> dev(new SkPDFDevice(pageSize, pageSize, SkMatrix::I()));

if (useDCTEncoder) {

dev->setDCTEncoder(encode_to_dct_stream);

« no previous file with comments | « no previous file | no next file » | no next file with comments »